Attention is currently required from: pespin.

View Change

2 comments:

• Patchset:

  • Patch Set #1:

    I'm fine with merging this, I know several places where we are actually generating a string in a sta […]

    ack -> separate patch

• File src/stream_cli.c:

  • Patch Set #1, Line 674: osmo_stream_cli_set_name_f(cli, "%s", name);

    I'd rather duplicate a couple lines than going through the whole vararg parsing here....

    two reasons to disagree:

    a) the vararg parsing is not the slow part, the talloc is. There is no optimization effect.

    b) IIUC this code happens when establishing links, so it is not performance relevant. So this clearly calls for avoiding code dup instead of optimizing.

To view, visit change 39310. To unsubscribe, or for help writing mail filters, visit settings.