Attention is currently required from: fixeria, laforge, pespin.

osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email )

Change subject: pcap-server: Make rotate-localtime feature configurable through VTY ......................................................................

Patch Set 3:

(2 comments)

File configure.ac:

https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/14e77d80_743b12b7?usp... : PS3, Line 65: dnl patching ${archive_cmds} to affect generation of file "libtool" to fix linking with clang

Well they start to be needed here since I'm adding unit tests for the feature I'm adding, I think it […]

Acknowledged

File src/osmo_server_vty.c:

https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/cd8cd9ec_e649c37e?usp... : PS3, Line 246: max_mod = 4294967295;

We cannot use it easily in DEFUN since stringifying it then adds eg. "UL" at the end. […]

Acknowledged