Attention is currently required from: fixeria, laforge, pespin.
osmith has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email )
Change subject: pcap-server: Make rotate-localtime feature configurable through VTY
......................................................................
Patch Set 3:
(2 comments)
File configure.ac:
https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/14e77d80_743b12b7?us… :
PS3, Line 65: dnl patching ${archive_cmds} to affect generation of file
"libtool" to fix linking with clang
Well they start to be needed here since I'm adding
unit tests for the feature I'm adding, I think it […]
Acknowledged
File src/osmo_server_vty.c:
https://gerrit.osmocom.org/c/osmo-pcap/+/39158/comment/cd8cd9ec_e649c37e?us… :
PS3, Line 246: max_mod = 4294967295;
We cannot use it easily in DEFUN since stringifying it
then adds eg. "UL" at the end. […]
Acknowledged
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcap/+/39158?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: Idf17a161c17050bb62793a82e39179a093b35f73
Gerrit-Change-Number: 39158
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Dec 2024 11:10:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>