[XS] Change in libosmocore[master]: osmo_io: Increase default queue max_length from 32 to 1024 - gerrit-log

25 Nov 2024


      Attention is currently required from: daniel, fixeria, jolly, pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/38886?usp=email )
Change subject: osmo_io: Increase default queue max_length from 32 to 1024
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
...
iofd_txqueue_enqueue() returns -ENOSPC. […]
I'm not sure that's great either.  It's wrong for an application to try to push millions of messages to a write queue without ever going through osmo_select_main and give the queue a chance to drain itself.
I agree for situations like Abis 32 is too little.  But 2 billion (or more in 64bit) clearly is too many...
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38886?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I92d5369af523f6297d45d4b534bb0f349ae74485
Gerrit-Change-Number: 38886
Gerrit-PatchSet: 1
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: jolly andreas@eversberg.eu
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: jolly andreas@eversberg.eu
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Comment-Date: Mon, 25 Nov 2024 16:17:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: jolly andreas@eversberg.eu
Comment-In-Reply-To: pespin pespin@sysmocom.de