Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34483?usp=email ) Change subject: ASCI: Add support flags to mobile (and VTY) for VGCS/VBS ...................................................................... Patch Set 5: (2 comments) File src/host/layer23/include/osmocom/bb/common/settings.h: https://gerrit.osmocom.org/c/osmocom-bb/+/34483/comment/f09958e4_144f9dd2 PS5, Line 165: uint8_t vgcs; /* support of VGCS */ bool I know others use uint8_t, but let's at least use bool for the new ones. The old ones should be moved to bool at some point. File src/host/layer23/src/common/support.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34483/comment/37c4dda6_097915dc PS5, Line 37: sup->vgcs = 1; /* yes */ = true -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34483?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia23eb190e533660cce4ba4c856a83b5f3d534202 Gerrit-Change-Number: 34483 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 21 Sep 2023 12:41:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment