Attention is currently required from: lynxis lazus, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/38435?usp=email )
Change subject: ranap: Fix decoding of padded ITU X.213 IPv4 TLA in Rab Ass Resp
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/sgsn/gprs_ranap.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/38435/comment/abc72c5a_802a4aaa?usp... :
PS1, Line 81: Unknown Transport Layer Address
"... unable/failed to decode Transport Layer Address ..."?
"unknown" is misleading, IMO
--
To view, visit
https://gerrit.osmocom.org/c/osmo-sgsn/+/38435?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I9c48b676068574338f60b6ed7ad8b61ba748b52e
Gerrit-Change-Number: 38435
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: lynxis lazus
lynxis@fe80.eu
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: lynxis lazus
lynxis@fe80.eu
Gerrit-Comment-Date: Tue, 15 Oct 2024 16:56:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes