[S] Change in libosmo-sigtran[master]: tcap: Support TID with length 1..4 - gerrit-log

26 Feb 2026


      Attention is currently required from: daniel, lynxis lazus, pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email )
Change subject: tcap: Support TID with length 1..4
......................................................................
Patch Set 2:
(1 comment)
File src/tcap_as_loadshare.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212/comment/8db50249_5a5901... :
PS2, Line 81: OSMO_ASSERT
why would we want to assert here? Does that mean anyone can crash osmo-stp or libosmo-sigtran by sending it a malformed TCAP message with length==0 or length>=5 ?
-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I2748d85624e4be708f7554ee3e60a5bda9162845
Gerrit-Change-Number: 42212
Gerrit-PatchSet: 2
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: lynxis lazus lynxis@fe80.eu
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Attention: lynxis lazus lynxis@fe80.eu
Gerrit-Comment-Date: Thu, 26 Feb 2026 10:34:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No