osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27886 )

Change subject: bts_model_osmobts_init: order feats alphabetically ......................................................................

bts_model_osmobts_init: order feats alphabetically

Order the features and add a comment that reminds of updating OsmoBTS to actually report the new features that are assumed to be supported here.

Related: SYS#5922, OS#5538 Change-Id: I6f041648990db4ae479538cf3970c826bc6703ed --- M src/osmo-bsc/bts_osmobts.c 1 file changed, 6 insertions(+), 4 deletions(-)

Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved

diff --git a/src/osmo-bsc/bts_osmobts.c b/src/osmo-bsc/bts_osmobts.c index 5c535be..f909c61 100644 --- a/src/osmo-bsc/bts_osmobts.c +++ b/src/osmo-bsc/bts_osmobts.c @@ -205,11 +205,13 @@ sizeof(model_osmobts._features_data); memset(model_osmobts.features.data, 0, model_osmobts.features.data_len);

- osmo_bts_set_feature(&model_osmobts.features, BTS_FEAT_GPRS); - osmo_bts_set_feature(&model_osmobts.features, BTS_FEAT_EGPRS); - osmo_bts_set_feature(&model_osmobts.features, BTS_FEAT_PAGING_COORDINATION); - osmo_bts_set_feature(&model_osmobts.features, BTS_FEAT_IPV6_NSVC); + /* Order alphabetically and remember to adjust bts_model_init in + * OsmoBTS to report new features. */ osmo_bts_set_feature(&model_osmobts.features, BTS_FEAT_CCN); + osmo_bts_set_feature(&model_osmobts.features, BTS_FEAT_EGPRS); + osmo_bts_set_feature(&model_osmobts.features, BTS_FEAT_GPRS); + osmo_bts_set_feature(&model_osmobts.features, BTS_FEAT_IPV6_NSVC); + osmo_bts_set_feature(&model_osmobts.features, BTS_FEAT_PAGING_COORDINATION);

model_osmobts.nm_att_tlvdef.def[NM_ATT_OSMO_NS_LINK_CFG].type = TLV_TYPE_TL16V;