[S] Change in libosmocore[master]: formalize log subsys stripping for vty - gerrit-log

9 Apr 2024


      Attention is currently required from: neels.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36545?usp=email )
Change subject: formalize log subsys stripping for vty
......................................................................
Patch Set 1:
(2 comments)
File src/core/logging.c:
https://gerrit.osmocom.org/c/libosmocore/+/36545/comment/6194be9b_913cbcc2 
PS1, Line 432: int cat_idx
probably a good idea to make it `unsigned`
https://gerrit.osmocom.org/c/libosmocore/+/36545/comment/2b5f6379_831a452e 
PS1, Line 434: 	const char *name = log_info->cat[cat_idx].name;
add `OSMO_ASSERT(cat_idx < log_info->num_cat)`?
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36545?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I5f81343e8c7b714a4630e64ba654e391435c4244
Gerrit-Change-Number: 36545
Gerrit-PatchSet: 1
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Comment-Date: Tue, 09 Apr 2024 12:14:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment