Change in libosmocore[master]: SI: add RR short PD message types - gerrit-log

24 Jan 2023


      Attention is currently required from: arehbein.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31048 )
Change subject: SI: add RR short PD message types
......................................................................
Patch Set 1:
(1 comment)
File include/osmocom/gsm/protocol/gsm_04_08.h:
https://gerrit.osmocom.org/c/libosmocore/+/31048/comment/d9e48f16_aea8003e 
PS1, Line 1553: #define GSM48_MT_RR_SH_SI10bis		0xA
...
Do we have a certain rule as to why the suffixes here and in the next line are in lower-case? Just w […]
Not that I know of but if you 'git grep' for 2bis/ter, 5bis/ter you'll see that those suffixes are not capitalized in sysinfo-related code so far.
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31048
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ifbd0aabe826298fa4715eb4eb2ff8363e765933d
Gerrit-Change-Number: 31048
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev msuraev@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein arehbein@sysmocom.de
Gerrit-Attention: arehbein arehbein@sysmocom.de
Gerrit-Comment-Date: Tue, 24 Jan 2023 07:56:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein arehbein@sysmocom.de
Gerrit-MessageType: comment