Attention is currently required from: dexter.

laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38118?usp=email )

Change subject: utils: get rid of enc_msisdn and dec_msisdn ......................................................................

Patch Set 8:

(1 comment)

Patchset:

PS8: I wouldn't have bothered, sorry. Why invest time in changing pySim.legacy.* at all, unless there's a clear bug that needs fixing? Likewiese, the same applies to pySim-{read,prog}. Those tools are designated legacy for a reason. Any change will just invest time in something that is scheduled for removal - and at the same time it risks breaking something in a suble way.

So the question to me is: Is this fixing a bug? If yes, then let's merge it. If not, then my suggestion would be to move {enc,dec}_msisdn from pySim.utils to pySim.legacy.utils which means it will be removed when we remove all of the legacy.