Attention is currently required from: dexter.
1 comment:
Patchset:
I wouldn't have bothered, sorry. Why invest time in changing pySim.legacy.* at all, unless there's a clear bug that needs fixing? Likewiese, the same applies to pySim-{read,prog}. Those tools are designated legacy for a reason. Any change will just invest time in something that is scheduled for removal - and at the same time it risks breaking something in a suble way.
So the question to me is: Is this fixing a bug? If yes, then let's merge it. If not, then my suggestion would be to move {enc,dec}_msisdn from pySim.utils to pySim.legacy.utils which means it will be removed when we remove all of the legacy.
To view, visit change 38118. To unsubscribe, or for help writing mail filters, visit settings.