Attention is currently required from: daniel, fixeria, matanp, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35747?usp=email )
Change subject: ctrl: Add ms power
......................................................................
Patch Set 7:
(2 comments)
File src/osmo-bsc/bts_trx_ts_lchan_ctrl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/35747/comment/0ef548bf_71d17c53
PS3, Line 2: * (C) 2013-2015 by Holger Hans Peter Freyther
: * (C) 2013-2022 by
Ack
I am not a Copyright expert, but this still does not look right to me. If this is the code you wrote, you should put your name and E-mail in the copyright header. It's usually Sysmocom employees who put `by sysmocom s.f.m.c. GmbH` here.
https://gerrit.osmocom.org/c/osmo-bsc/+/35747/comment/f134f613_a328c67a
PS3, Line 17: * You should have received a copy of the GNU Affero General Public License
:
No need to remove this whole part.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/35747?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6f556b66011be6126d6bac31a14101ba37f81cc4
Gerrit-Change-Number: 35747
Gerrit-PatchSet: 7
Gerrit-Owner: matanp
matan1008@gmail.com
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: fixeria
axilirator@gmail.com
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: daniel
dwillmann@sysmocom.de
Gerrit-Attention: fixeria
axilirator@gmail.com
Gerrit-Attention: matanp
matan1008@gmail.com
Gerrit-Comment-Date: Wed, 14 Feb 2024 10:40:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Comment-In-Reply-To: matanp
matan1008@gmail.com
Gerrit-MessageType: comment