Attention is currently required from: neels, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/33216 )
Change subject: osmo_sccp_simple_client_on_ss7_id(): Fail to start a client on an ASP explicitly configured as sctp server ......................................................................
Patch Set 2:
(1 comment)
File src/sccp_user.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/33216/comment/00b85a53_130da9dd PS1, Line 633: if (default_local_ip)
we could simply move the line 652 "asp->cfg. […]
I think in the end a slightly confusing code with huge additional functionality to the user might be worth it?
side-note: The idea of the simple_client (when I created it) was to have a demo/example for other developers not intricately familiar with SCCP/SS7 yet and somethig that can be used in test cases/executables. I don't think the idea was to have it widely used up to the point that all osmocom libosmo-sigtran users (other than osmo-stp) use it rather than the normal API.