Change in osmo-bsc[master]: abis_rsl: show full request reference in log - gerrit-log

27 Oct 2022


      Attention is currently required from: laforge, pespin, lynxis lazus.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29703 )
Change subject: abis_rsl: show full request reference in log
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
...
I also argue that the FN is much more reasonable/useful than the partial T1/T2/T3 values. […]
At that point in the code the frame number isn't calculated yet. We could calculate it though, but I think it is better to print what values actually were in the Channel Request. At least for me printing those values helped a lot to debug the issue I was debugging.
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29703
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I78499b49ae176b736e384e193fadc0bdd669dffa
Gerrit-Change-Number: 29703
Gerrit-PatchSet: 3
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: lynxis lazus lynxis@fe80.eu
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: lynxis lazus lynxis@fe80.eu
Gerrit-Comment-Date: Thu, 27 Oct 2022 12:36:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge laforge@osmocom.org
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment