fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41614?usp=email )
Change subject: sctp_proxy: fix wrong operator in connecting/3 ......................................................................
sctp_proxy: fix wrong operator in connecting/3
We need to update the map, thus the update operation (`=>`) needs to be used, not the matching (`:=`). We're lucky that eNBs usually do not send anything before the MME responds to the S1Setup request; otherwise the S1GW would crash here due to a mismatch.
Change-Id: I26d8a8da5cce89324a9e1150e4ecdf2084d097c8 --- M src/sctp_proxy.erl 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved pespin: Looks good to me, but someone else must approve
diff --git a/src/sctp_proxy.erl b/src/sctp_proxy.erl index ad58d4b..458c53a 100644 --- a/src/sctp_proxy.erl +++ b/src/sctp_proxy.erl @@ -133,7 +133,7 @@ #{tx_queue := Pending} = S) -> s1gw_metrics:ctr_inc(?S1GW_CTR_S1AP_PROXY_UPLINK_PACKETS_QUEUED), s1gw_metrics:gauge_inc(?S1GW_GAUGE_S1AP_PROXY_UPLINK_PACKETS_QUEUED), - {keep_state, S#{tx_queue := [Data | Pending]}}; + {keep_state, S#{tx_queue => [Data | Pending]}};
%% Handle an #sctp_assoc_change event (connection state) connecting(info, {sctp, _Socket, MmeAddr, MmePort,