Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email ) Change subject: add libvlr based on MSC commit 25362cc295036a4671804db9003c3d22a88309d2 ...................................................................... Patch Set 1: (32 comments) File include/osmocom/vlr/vlr.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/30ce14a4_08927aae?us… : PS1, Line 121: long long unsigned int id; type 'long long unsigned int' should be specified in [[un]signed] [short|int|long|long long] order File src/libvlr/vlr.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/36ee17ed_45d98a9a?us… : PS1, Line 238: OSMO_STRBUF_PRINTF(sb, "%sMSISDN-%s", present? ":" : "", vsub->msisdn); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/3282d6e5_97653293?us… : PS1, Line 242: OSMO_STRBUF_PRINTF(sb, "%sTMSI-0x%08X", present? ":" : "", vsub->tmsi); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/943adeb0_b4c9dcfd?us… : PS1, Line 246: OSMO_STRBUF_PRINTF(sb, "%sTMSInew-0x%08X", present? ":" : "", vsub->tmsi_new); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/8f9191d6_2c999b1b?us… : PS1, Line 258: char *name = (char*)vlr_subscr_name(vsub); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/efcaf8d6_9afc23dd?us… : PS1, Line 263: strcpy(name + maxlen - 2, ".."); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/7fece6d8_db49bf31?us… : PS1, Line 380: vlr_subscr_name(vsub), (e->count - old_use_count) > 0? "+" : "-", e->use, spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/50e3dc39_8e6b6088?us… : PS1, Line 705: osmo_plmn_name(&vsub->sgs.last_eutran_plmn) : code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/6d83c633_5dad5863?us… : PS1, Line 810: struct sgsn_subscriber_pdp_data* pdata; "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/057b7867_ccfe033c?us… : PS1, Line 1447: VLR_AUTH_E_MS_ID_IMSI, (void*)mi->imsi); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/c8536e10_790fb350?us… : PS1, Line 1455: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMSI, (void*)mi->imsi); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/83436984_94a4b401?us… : PS1, Line 1457: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMEI, (void*)mi->imei); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/4fdd2728_87f519a6?us… : PS1, Line 1459: return osmo_fsm_inst_dispatch(vsub->lu_fsm, VLR_ULA_E_ID_IMEISV, (void*)mi->imeisv); "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/d79a85bc_dc68315a?us… : PS1, Line 1716: struct vlr_subscr **fsub = (void*)&target->filter_data[LOG_FLT_VLR_SUBSCR]; "(foo*)" should be "(foo *)" File src/libvlr/vlr_access_req_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/9f6e2d3d_6fd08ab1?us… : PS1, Line 111: return par->result? gsm48_reject_value_name(par->result) : "PASSED"; spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/179c7ad1_d8c6cb00?us… : PS1, Line 415: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/2ae208fe_b94e8551?us… : PS1, Line 421: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/6e21decb_2609fbec?us… : PS1, Line 496: result = *(enum vlr_ciph_result_cause*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/48f07d72_f27f4e87?us… : PS1, Line 791: .in_event_mask = , space prohibited before that ',' (ctx:WxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/3b3c69d6_368843aa?us… : PS1, Line 798: .in_event_mask = , space prohibited before that ',' (ctx:WxE) File src/libvlr/vlr_auth_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/920afee1_07203e97?us… : PS1, Line 199: res_len, (res_len == vec->res_len)? "valid" : "INVALID on UTRAN"); spaces required around that '?' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/2d1bb2f0_42445ac2?us… : PS1, Line 216: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/37626023_63c0098a?us… : PS1, Line 543: strncpy(vsub->imsi, mi_string, sizeof(vsub->imsi)); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() File src/libvlr/vlr_lu_fsm.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/1c28cb02_9f6ca16b?us… : PS1, Line 160: return (struct vlr_subscr*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/bf8da292_430f6f9f?us… : PS1, Line 272: return (struct vlr_subscr*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/68c2689f_61e794bb?us… : PS1, Line 667: return (struct lu_compl_vlr_priv*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/8b0ad4b4_1bdf0d3a?us… : PS1, Line 1282: result = *(enum vlr_ciph_result_cause*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/a4c2e520_c43a72b6?us… : PS1, Line 1404: cause = *(uint8_t*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/f7020fbb_5031d517?us… : PS1, Line 1436: cause = *(uint8_t*)data; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/a8430c51_9c812556?us… : PS1, Line 1643: return (struct lu_fsm_priv*)fi->priv; "(foo*)" should be "(foo *)" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/5e65665a_c59f8cbc?us… : PS1, Line 1691: strncpy(lfp->imsi, imsi, sizeof(lfp->imsi)-1); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() File src/libvlr/vlr_sgs.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21542): https://gerrit.osmocom.org/c/osmo-sgsn/+/39560/comment/9f6a889d_c1208a9b?us… : PS1, Line 324: } void function return statements are not generally useful -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39560?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I221114e00e6f338a75ae0dd7ac285e262b23635d Gerrit-Change-Number: 39560 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Sun, 16 Feb 2025 21:09:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No