Attention is currently required from: dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33418 )
Change subject: BTS_Tests: Add support for PCUIF protocol version 11 ......................................................................
Patch Set 1:
(2 comments)
File library/PCUIF_CodecPort.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33418/comment/724629bd_9147b... PS1, Line 173: cosmetic: no need for another tab-level here
File library/PCUIF_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33418/comment/0a4b8a9f_4944e... PS1, Line 376: enc_PCUIF_pch_dt We usually declare enc/dec functions close to the record they operate on. This is not critical, but I would recommend declaring it right after `PCUIF_pch_dt`, not near `PCUIF_Message`.