Attention is currently required from: jolly, laforge, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33144 )
Change subject: BSSMAP_Templates: Add templates to receive CellID IE
......................................................................
Patch Set 4:
(2 comments)
File library/BSSMAP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33144/comment/6608da07_978c…
PS1, Line 371: template BSSMAP_IE_CellIdentifier tr_CellId_CGI(hexstring mcc, hexstring
mnc, BssmapLAC lac, BssmapCI ci)
this looks really strange: a tr_* template having only
value params, modifying another tr template, […]
Done
File library/BSSMAP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33144/comment/aa636db1_8596…
PS3, Line 441: template BSSMAP_IE_CellIdentifier tr_CellID_SAI(template (present) OCT3
mcc_mnc,
template (present) here, as I guess there's no way
that it could return anything else
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33144
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I42d52d871c8011db7e0897dfe752afeefa6d9662
Gerrit-Change-Number: 33144
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 09 Jun 2023 14:05:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment