Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36507?usp=email ) Change subject: esim.es2p: Permit ApiParamInteger to be an actual integer ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: Maybe this is already done somewhere, but if not: it would probably be a good idea to explicitly turn it into a string somewhere. Otherwise code dealing with it may assume it is a string and then could result in an error elsewhere in the code? PS1: Fix is in https://gerrit.osmocom.org/c/docker-playground/+/36516, already deployed it to show it works -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36507?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5b47f8bba01225d53eff2ca086e53a2133abed7f Gerrit-Change-Number: 36507 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 03 Apr 2024 11:49:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment