Attention is currently required from: laforge, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30703 )

Change subject: libosmocore: Transition to use of 'telnet_init_default' ......................................................................

Patch Set 4:

(2 comments)

File src/vty/telnet_interface.c:

https://gerrit.osmocom.org/c/libosmocore/+/30703/comment/6ff617a5_cb97322a PS2, Line 71: #pragma GCC diagnostic push

I suppose so

Done

File src/vty/telnet_interface.c:

https://gerrit.osmocom.org/c/libosmocore/+/30703/comment/f864ca37_e943a752 PS3, Line 110: int telnet_init_dynif(void *tall_ctx, void *priv, const char *ip, int port)

You missed calling _telnet_init_dynif() in here instead of duplicating code.

yeah thanks for the heads up, noticed it looking at my patchset