[XS] Change in ...osmo-epdg[master]: s2b: add logline on terminating module - gerrit-log

23 May 2025


      Attention is currently required from: lynxis lazus.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37902?usp=email )
Change subject: s2b: add logline on terminating module
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File src/epdg_gtpc_s2b.erl:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37902/comment/c2be4cc2_d59c7... :
PS1, Line 206: State
Do we really want/need to log the state here?
And why do you log it as `error` given that it's `normal`?
-- 
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37902?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I7a3665b0a77ac86bed448a18cf224e2f6954ba73
Gerrit-Change-Number: 37902
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: lynxis lazus lynxis@fe80.eu
Gerrit-Comment-Date: Fri, 23 May 2025 06:13:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes