Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35504?usp=email )
Change subject: gsm: fix osmo_mobile_identity_decode(): init *mi on error
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
It shouldn't matter in principle since callers
should check the return value, but fine.
Doxygen docs for this function claim that
`*mi` is initialized even in case of an error, and this is the case for most early-return
error scenarios except for this one.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35504?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1c1503120c6c0e5479d8350fe762470bdb6266b8
Gerrit-Change-Number: 35504
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Jan 2024 16:07:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment