Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30148 )
Change subject: osmux: Rework log formatting when replaying detected RTP gaps ......................................................................
Patch Set 1:
(1 comment)
File src/osmux_input.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/30148/comment/a2c54787_edff819a PS1, Line 366: d did you consider sequence wrap-around here? What if for example last_seq == 65535 and cur_seq == 0 or 1?
Also, are you sure that the arithmetic works out, if you express the difference between two arbitrary uint16_t as int16_t? What about differences that are larger than possible to express in int16_t?