Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30148 ) Change subject: osmux: Rework log formatting when replaying detected RTP gaps ...................................................................... Patch Set 1: (1 comment) File src/osmux_input.c: https://gerrit.osmocom.org/c/libosmo-netif/+/30148/comment/a2c54787_edff819a PS1, Line 366: d did you consider sequence wrap-around here? What if for example last_seq == 65535 and cur_seq == 0 or 1? Also, are you sure that the arithmetic works out, if you express the difference between two arbitrary uint16_t as int16_t? What about differences that are larger than possible to express in int16_t? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30148 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5fd64acf7bc1e53efae0674d0c906d1255a9bbf6 Gerrit-Change-Number: 30148 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 19:32:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment