Attention is currently required from: keith, neels.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/16222?usp=email )
Change subject: forward SDP between SIP and MNCC
......................................................................
Patch Set 7:
(1 comment)
File src/sdp.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11015):
https://gerrit.osmocom.org/c/osmo-sip-connector/+/16222/comment/27f1117d_cbc...
PS7, Line 261: osmo_sockaddr_ntop((const struct sockaddr*)&other->addr, ip_addr);
"(foo*)" should be "(foo *)"
--
To view, visit
https://gerrit.osmocom.org/c/osmo-sip-connector/+/16222?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I3df5d06f38ee2d122706a9ebffde7db4f2bd6bae
Gerrit-Change-Number: 16222
Gerrit-PatchSet: 7
Gerrit-Owner: neels
nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith
keith@rhizomatica.org
Gerrit-Reviewer: neels
nhofmeyr@sysmocom.de
Gerrit-Attention: neels
nhofmeyr@sysmocom.de
Gerrit-Attention: keith
keith@rhizomatica.org
Gerrit-Comment-Date: Wed, 13 Sep 2023 22:17:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment