Attention is currently required from: dexter, fixeria.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34960?usp=email )

Change subject: transport/pcsc: Allow opening PC/SC readers by a regex of their name ......................................................................

Patch Set 2:

(2 comments)

File pySim/transport/pcsc.py:

https://gerrit.osmocom.org/c/pysim/+/34960/comment/7093488e_34e7c377 PS2, Line 50: is_a_number(reader_number):

Looks like you always expect `reader_number` to be a string: either with the reader number or a rege […]

you are right. The point is that the only current caller always passes a string, and that might be an integer or something else. I forgot that a future other caller might actually pas an int.

https://gerrit.osmocom.org/c/pysim/+/34960/comment/69384e61_7df80510 PS2, Line 132: '--pcsc-device

(just a suggestion) maybe keep this argument unchanged (and keep it as `int`), and add another one l […]

I thought about this, but sadly the constructor doesn't get passed the full 'opts' from the argparser, so adding arguments requires also modifications elsewhere. I'll have a look and try to clean this up.