Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671?usp=email ) Change subject: hlr: refactor f_SS_expect() ...................................................................... Patch Set 1: (4 comments) File hlr/HLR_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671/comment/df8a34c0_52bc… : PS1, Line 740: Looks like we want to have this in a function in GSUP_Templates.ttcn maybe? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671/comment/a669e531_2f13… : PS1, Line 741: /* case a) SS Info is can be any value or not present */ "is can be" <-wrong https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671/comment/2bce2ed7_f89d… : PS1, Line 746: /* case b) SS Info is shall *not* be present */ "is shall" all this is gramaptically incorrect, remove the "is" please. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671/comment/a0efdf73_2dde… : PS1, Line 755: /* case c) SS Info is shall be present */ same -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I162a79e3c7ff9dafb031e3da8a78af313534cac7 Gerrit-Change-Number: 38671 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Comment-Date: Wed, 06 Nov 2024 15:52:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No