Attention is currently required from: fixeria.

pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671?usp=email )

Change subject: hlr: refactor f_SS_expect() ......................................................................

Patch Set 1:

(4 comments)

File hlr/HLR_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671/comment/df8a34c0_52bc4... : PS1, Line 740: Looks like we want to have this in a function in GSUP_Templates.ttcn maybe?

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671/comment/a669e531_2f136... : PS1, Line 741: /* case a) SS Info is can be any value or not present */ "is can be" <-wrong

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671/comment/2bce2ed7_f89dc... : PS1, Line 746: /* case b) SS Info is shall *not* be present */ "is shall" all this is gramaptically incorrect, remove the "is" please.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38671/comment/a0efdf73_2ddea... : PS1, Line 755: /* case c) SS Info is shall be present */ same