Attention is currently required from: lynxis lazus. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/38764?usp=email ) Change subject: gsm_utils: add gprs_tlli2tmsi() ...................................................................... Patch Set 3: (2 comments) File src/gsm/gsm_utils.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19919): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/12040c4e_a136b7f3?… : PS3, Line 1031: switch (gprs_tlli_type(tlli)) { switch and case should be at the same indent File tests/gprs/gprs_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19919): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/8c45c00c_4ea05227?… : PS3, Line 113: static void test_ptmsi_tlli() Bad function definition - void test_ptmsi_tlli() should probably be void test_ptmsi_tlli(void) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38764?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9d3464922c89383099a5f3cdd1458c0ecc28ee18 Gerrit-Change-Number: 38764 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 14 Nov 2024 17:50:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No