Attention is currently required from: fixeria, jolly, laforge, pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36547?usp=email )
Change subject: asterisk: Introduce test TC_internal_call_momt ......................................................................
Patch Set 3: Code-Review+1
(3 comments)
File asterisk/Asterisk_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36547/comment/1a309a15_7b92a... PS2, Line 103: type record CallParsComputed maybe explain in the commit msg the reasoning for merging CallParsComputed to CallPars?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36547/comment/d2cf2cdb_c4e2c... PS2, Line 193: log2str(g_name & ": Received unexpected SIP Req message := ", sip_req)); maybe also print "vs exp :=" here, like in as_SIP_fail_resp?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36547/comment/05fe4c9b_e605c... PS2, Line 236: }; */ do you want to keep this?
-
osmith