Jenkins Builder has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40051?usp=email ) Change subject: trx_toolkit/fake_trx: Split it into fake_trx and _fake_trx modules ...................................................................... Patch Set 1: (2 comments) File src/target/trx_toolkit/_fake_trx.py: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/40051/comment/1b505f69_07fd4d5d?u… : PS1, Line 216: msg.burst = None # burst bits are omited 'omited' may be misspelled - perhaps 'omitted'? Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/40051/comment/28e7a449_edbf9a6e?u… : PS1, Line 218: # TODO: shoud we make these values configurable? 'shoud' may be misspelled - perhaps 'should'? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/40051?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iadffd49de8197564e57bfd9cb660b1d11136ffd4 Gerrit-Change-Number: 40051 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-CC: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 17 Apr 2025 09:52:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No