Attention is currently required from: laforge, pespin.
Hoernchen has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/38003?usp=email )
Change subject: Fix building in environments that define _GNU_SOURCE
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I also think libosmocore should be more resilient and the behaviour we want here is "make sure _GNU_ […]
This is like attempts to force LTO or randomly add -ffast-math, the expected behavior if random flags and defines are added by "the environment" is that everything breaks, just like distro provided stack protectors and other stuff that interfered with simtrace fw builds and had to be disabled.
The assumption is that we know what is defined and enabled at the top of a translation unit.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/38003?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I36cb3a5555cb35ddc44f06d447268bd9cc0ce9b4
Gerrit-Change-Number: 38003
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
laforge@osmocom.org
Gerrit-Reviewer: Hoernchen
ewild@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Tue, 03 Sep 2024 15:00:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen
ewild@sysmocom.de
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: pespin
pespin@sysmocom.de