jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/33821 ) Change subject: ASCI: Null pointer bug fix in trans_create_bcc_gcc ...................................................................... ASCI: Null pointer bug fix in trans_create_bcc_gcc Fixes: CID#322147 Change-Id: I1676d3cbf844930a6a433253f055a3f8fe3c210b --- M src/libmsc/msc_vgcs.c 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/21/33821/1 diff --git a/src/libmsc/msc_vgcs.c b/src/libmsc/msc_vgcs.c index 1af9aae..8edda6b 100644 --- a/src/libmsc/msc_vgcs.c +++ b/src/libmsc/msc_vgcs.c @@ -1321,8 +1321,8 @@ static struct gsm_trans *trans_create_bcc_gcc(struct msc_a *msc_a, enum trans_type trans_type, uint8_t transaction_id, uint8_t pdisc, uint8_t msg_type, uint32_t callref) { - struct gsm_network *net = msc_a_net(msc_a); - struct vlr_subscr *vsub = msc_a_vsub(msc_a); + struct gsm_network *net; + struct vlr_subscr *vsub; struct gsm_trans *trans = NULL; struct gcr *gcr; int rc; @@ -1331,6 +1331,9 @@ LOG_GCC(trans, LOGL_ERROR, "Invalid conn: no msc_a\n"); return NULL; } + net = msc_a_net(msc_a); + vsub = msc_a_vsub(msc_a); + if (!vsub) { LOG_GCC(trans, LOGL_ERROR, "Invalid conn: no subscriber\n"); return NULL; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I1676d3cbf844930a6a433253f055a3f8fe3c210b Gerrit-Change-Number: 33821 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange