daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35131?usp=email )

Change subject: coding: gsm0503_tch_{afs,ahs}_encode(): add ability to emit BFI ......................................................................

Patch Set 2:

(1 comment)

File src/coding/gsm0503_coding.c:

https://gerrit.osmocom.org/c/libosmocore/+/35131/comment/b498414c_ac020e9e PS2, Line 2476: if (!len) { This is already very repetetive and now even more so. Could you just set tch_len, <whatever 81 in osmo_crc8gen_set_bits is) and gsm0503_conv_fn in the switch statement and then have a generic part after that checks for !len and does the memset/calls these functions with the appropriate parameters.