View Change

1 comment:

• File src/coding/gsm0503_coding.c:

  • Patch Set #2, Line 2476: if (!len) {

    This is already very repetetive and now even more so. Could you just set tch_len, <whatever 81 in osmo_crc8gen_set_bits is) and gsm0503_conv_fn in the switch statement and then have a generic part after that checks for !len and does the memset/calls these functions with the appropriate parameters.

To view, visit change 35131. To unsubscribe, or for help writing mail filters, visit settings.