[S] Change in libosmocore[master]: gsm48_ie.c: change bearer cap structure in outgoing CSD calls - gerrit-log

14 Oct 2023


      Attention is currently required from: laforge, manawyrm.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34746?usp=email )
Change subject: gsm48_ie.c: change bearer cap structure in outgoing CSD calls
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patchset:
PS4: 
Looks good and I vote for merging it. Just wanted to say that ideally we should also make the encoding of this octet configurable via the struct passed to the encoding function.
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34746?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ieb5bca3d3578abd28e18808752e1c312ce7c4ce0
Gerrit-Change-Number: 34746
Gerrit-PatchSet: 4
Gerrit-Owner: manawyrm osmocom.account@tbspace.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Attention: manawyrm osmocom.account@tbspace.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Comment-Date: Sat, 14 Oct 2023 20:12:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment