Attention is currently required from: fixeria, laforge, pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396?usp=email )

Change subject: SGSN: BSSGP_ConnHdlr: GMM Service Request: add support to expect authentication ......................................................................

Patch Set 4:

(3 comments)

Patchset:

PS3:

All my comments marked Done, but nothing changed?

I think I'ven't yet pushed again.

File sgsn/BSSGP_ConnHdlr.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/436bc62e_a353b... : PS4, Line 358: as_gmm_auth

You're adding this altstep, but not using it? Is it for a follow-up patch? I see there's also `f_gmm […]

no it doesn't. f_gmm_auth() requires and expect to get certain parts in a specific way. also it fails if you don't have an auth. On certain tests, the test might not care, if an auth happened, just do an auth, if it is required.

f_gmm_auth() requires to have an auth. it can also not used in alt steps.

Yes there is an upcoming SGSN Context Request commit, which needs this.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38396/comment/08d6de13_c0f09... : PS4, Line 363: Ignoring autn for now

TODO? `f_gmm_auth()` does handle AUTN, by the way.

Yes, this is copied from the f_gmm_auth().