Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29530 ) Change subject: Allocate struct osmux_in_handle through new libosmo-netif APIs ...................................................................... Patch Set 1: (1 comment) File src/common/osmux.c: https://gerrit.osmocom.org/c/osmo-bts/+/29530/comment/d20ad901_8a96fc80 PS1, Line 141: TALLOC_FREE it's a standard talloc API (define) and already used in several places. It calls talloc_free and sets the pointer to NULL. I know the h structure is being freed immediately afterwards, but I prefer setting this as NULL in order to avoid weird accesses in the future in case there's some talloc destructor set in the parent "h" structure. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I132a7c03213cb20dfe118616c8cfd7032b075507 Gerrit-Change-Number: 29530 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 30 Sep 2022 11:48:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment