pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33885 ) Change subject: rlcmac: rlc_window_dl: Fix RBB generation ...................................................................... rlcmac: rlc_window_dl: Fix RBB generation We want to do mod sns on the BSN, not on the boolean returned by gprs_rlcmac_rlc_v_n_is_received(). This is a typo which occurred while porting the code from osmo-pcu.git void gprs_rlc_ul_window::update_rbb(char *rbb), where the following line is used: """ if (m_v_n.is_received((ssn()-1-i) & mod_sns())) """ Change-Id: I37c8fd5c2528f035f077c3e05105f913922ffd84 --- M src/rlcmac/rlc_window_dl.c 1 file changed, 19 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/rlcmac/rlc_window_dl.c b/src/rlcmac/rlc_window_dl.c index a2bef5f..77153b6 100644 --- a/src/rlcmac/rlc_window_dl.c +++ b/src/rlcmac/rlc_window_dl.c @@ -163,7 +163,7 @@ unsigned int i; for (i = 0; i < ws; i++) { - if (gprs_rlcmac_rlc_v_n_is_received(&dlw->v_n, ssn - 1 - i) & mod_sns) + if (gprs_rlcmac_rlc_v_n_is_received(&dlw->v_n, (ssn - 1 - i) & mod_sns)) rbb[ws - 1 - i] = 'R'; else rbb[ws - 1 - i] = 'I'; -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/33885 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I37c8fd5c2528f035f077c3e05105f913922ffd84 Gerrit-Change-Number: 33885 Gerrit-PatchSet: 1 Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-MessageType: merged