Attention is currently required from: pespin.
falconia has posted comments on this change by falconia. (
https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email )
Change subject: bring twrtp into libosmo-netif
......................................................................
Patch Set 5:
(1 comment)
File src/twrtp_base.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/4d6e95a1_8c237d4… :
PS1, Line 132: * another variant of this API with that alternative behavior.
See 3GPP TS 25.414 clause 5.1.3.4. RTCP is optional in
IuUP. […]
I see what you are asking for now. In order to make it consistent, we
would need to not only allow absent `rtcp_fd` in the low-level API
`osmo_twrtp_supply_fds()`, but also add a Boolean argument to the higher-level API
`osmo_twrtp_bind_local()`, enabling or disabling creation and binding of RTCP socket.
Before I implement it in the next patch iteration, please confirm that this is what you
want.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ib63215aaf13ef8ab8f2e0c8d310164cd5c8824eb
Gerrit-Change-Number: 39281
Gerrit-PatchSet: 5
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Aug 2025 16:44:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>