Attention is currently required from: neels, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31299 )

Change subject: socket: propagate error in osmo_sock_unix_init() to the caller ......................................................................

Patch Set 2:

(5 comments)

File src/core/socket.c:

https://gerrit.osmocom.org/c/libosmocore/+/31299/comment/fd122a3f_0ff517bc PS1, Line 1422: return -1;

agree […]

Done

https://gerrit.osmocom.org/c/libosmocore/+/31299/comment/048ac443_ab8f36f7 PS1, Line 1422: return -1;

agree […]

Done

https://gerrit.osmocom.org/c/libosmocore/+/31299/comment/00b05fd3_e7cee7bb PS1, Line 1396: sfd

This is not really a change: according to the manpage, in case of an error "a value of -1 shall be r […]

Done

https://gerrit.osmocom.org/c/libosmocore/+/31299/comment/ae7a277a_80609d90 PS1, Line 1420: sfd = rc;

If you keep the 'err' label, you can just do 'goto' here.

Done

File src/core/socket.c:

https://gerrit.osmocom.org/c/libosmocore/+/31299/comment/82464c85_3d902cbd PS2, Line 1401: close(sfd);

rather keep the 'goto err', instead of duplicating the exit-cleanup code

Done