Attention is currently required from: neels, fixeria.

View Change

5 comments:

• File src/core/socket.c:

  • Patch Set #1, Line 1422: return -1;

    agree […]

    Done

  • Patch Set #1, Line 1422: return -1;

    agree […]

    Done

  • Patch Set #1, Line 1396: sfd

    This is not really a change: according to the manpage, in case of an error "a value of -1 shall be r […]

    Done

  • Patch Set #1, Line 1420: sfd = rc;

    If you keep the 'err' label, you can just do 'goto' here.

    Done

• File src/core/socket.c:

  • Patch Set #2, Line 1401: close(sfd);

    rather keep the 'goto err', instead of duplicating the exit-cleanup code

    Done

To view, visit change 31299. To unsubscribe, or for help writing mail filters, visit settings.