Attention is currently required from: dexter, fixeria, laforge.
osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38254?usp=email )
Change subject: tests: sanitize all cards before running tests
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/38254/comment/cff01c75_faa2b96e?usp=ema... :
PS4, Line 14: let's reset the cards to a defined state before
: running the actual tests
I don't think this patch actually executes anything "before running the test"? It seems to merely […]
right, this commit message made sense in the first version of the patch. instead of running it in jenkins.sh, it now runs with a separate, nightly jenkins job.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/38254?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I42eaf61280968518164f2280245136fd30a603ce
Gerrit-Change-Number: 38254
Gerrit-PatchSet: 4
Gerrit-Owner: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-CC: fixeria
vyanitskiy@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Fri, 04 Oct 2024 08:13:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org
osmith