Attention is currently required from: fixeria, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34811?usp=email ) Change subject: mobile: vty: rework support enable/disable commands ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/host/layer23/src/mobile/vty_interface.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34811/comment/bbfaa42c_19e2da88 PS1, Line 2019: struct osmocom_ms *ms = vty->index; \ Did you think about having all this code in a single helper function where you pass a bool* to it? This way we'd avoid tons of functions duplicating code. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34811?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibfef31f6dd7694dad535ad07fdf47bd32571b7b2 Gerrit-Change-Number: 34811 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Oct 2023 11:48:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment