Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31144 ) Change subject: pcu_sock: transfer E1 connection information to PCU ...................................................................... Patch Set 2: (4 comments) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/eb141a5d_3015d42e PS1, Line 315: struct gsm_bts_trx_ts *ts; I don't think that it is a good idea to declare the variables in other places as at the top of a function. https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/5d1349d1_1e1fc31b PS1, Line 318: OSMO_ASSERT(bts); Done https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/456aa844_6078b436 PS1, Line 323: gsm_bts_trx_num Done https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/59bb91b1_56ada277 PS1, Line 326: if (trx->nr >= PCU_IF_NUM_TRX) oh, yes, but now it should make sense since now I am using the list, which is not limited to PCU_IF_NUM_TRX -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6d44373336b41009ff4c6e459d32d0a81081676c Gerrit-Change-Number: 31144 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 03 Feb 2023 11:46:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment