Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31144 )
Change subject: pcu_sock: transfer E1 connection information to PCU ......................................................................
Patch Set 2:
(4 comments)
File src/osmo-bsc/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/eb141a5d_3015d42e PS1, Line 315: struct gsm_bts_trx_ts *ts;
can be moved to the scope where it's used (inner for loop)
I don't think that it is a good idea to declare the variables in other places as at the top of a function.
https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/5d1349d1_1e1fc31b PS1, Line 318: OSMO_ASSERT(bts);
So you're removing these asserts in I8320cbc14361438d65642d15bc225e9960ce925b, but adding them here? […]
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/456aa844_6078b436 PS1, Line 323: gsm_bts_trx_num
This function is good for random access (give me Nth TRX), but really bad for sequential access beca […]
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/31144/comment/59bb91b1_56ada277 PS1, Line 326: if (trx->nr >= PCU_IF_NUM_TRX)
This condition is always false because you're doing i < PCU_IF_NUM_TRX. CR-1.
oh, yes, but now it should make sense since now I am using the list, which is not limited to PCU_IF_NUM_TRX
-
dexter