Attention is currently required from: neels, pespin, fixeria.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29353 )
Change subject: osmux: Use local/remote CID terminology
......................................................................
Patch Set 2:
(5 comments)
File common/chapters/osmux/mgcp_extension_osmux.adoc:
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29353/comment/d3a1cdc1_ab92…
PS1, Line 46: original _remote CID_ sent during `CRCX`. The same way, all `MDCX` response
shall
"MGW's remote CID" to clarify beyond
doubt ... […]
Done
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29353/comment/9398f632_ebd3…
PS1, Line 75: MGW's <<remote CID>>
if this was recvCID before, it should now either be
MGW's local CID or peer's remote CID according t […]
Done
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29353/comment/b2daad41_8ae6…
PS1, Line 75: .Example: response to `CRCX` containing the MGW's <<remote
CID>>
are you sure a space in a reference link works? […]
Done
File common/chapters/osmux/osmux.adoc:
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29353/comment/c290fb12_addc…
PS1, Line 55: frames the local
sentence lost meaning
still unresolved
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29353/comment/e19443c3_31e7…
PS1, Line 55: send Osmux frames the
"send Osmux frames to the"? (missing
"to")
still unresolved
--
To view, visit
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/29353
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: Ia5eb833c296c504555f273a7fc3af5d746af19c0
Gerrit-Change-Number: 29353
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Sep 2022 14:52:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment