Attention is currently required from: laforge, pespin, fixeria, dexter.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31417 )
Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload ......................................................................
Patch Set 3:
(3 comments)
File src/common/l1sap.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3962): https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/1b636c06_cbff5196 PS3, Line 1267: } else else is not generally useful after a break or return
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3962): https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/1054646a_528c74fc PS3, Line 1267: } else suspect code indent for conditional statements (16, 20)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3962): https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/ae73c8de_3c962c29 PS3, Line 1268: if (OSMO_UNLIKELY Statements should start on a tabstop