Attention is currently required from: daniel, laforge, pespin.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )

Change subject: gsmtap: Hide implementation of gsmtap_inst ......................................................................

Patch Set 3: Code-Review-1

(3 comments)

File TODO-RELEASE:

https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/191b6602_76b8b7be PS3, Line 11: core ADD gsmtap_inst_fd2() append: (Deprecate gsmtap_inst_fd())

File include/osmocom/core/gsmtap_util.h:

https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/6c7449f5_c9f7f6e6 PS3, Line 32: int gsmtap_inst_fd2(struct gsmtap_inst *gti); while at it, make gti const :)

File src/core/logging_gsmtap.c:

https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/14ca953a_3e11f19f PS3, Line 54: struct gsmtap_inst; This is not needed, you are already adding gsmtap_util.h abovewhich adds this line.