Attention is currently required from: daniel, laforge, pespin.

Patch set 3:Code-Review -1

View Change

3 comments:

• File TODO-RELEASE:

  • Patch Set #3, Line 11: core ADD gsmtap_inst_fd2()

    append: (Deprecate gsmtap_inst_fd())

• File include/osmocom/core/gsmtap_util.h:

  • Patch Set #3, Line 32: int gsmtap_inst_fd2(struct gsmtap_inst *gti);

    while at it, make gti const :)

• File src/core/logging_gsmtap.c:

  • Patch Set #3, Line 54: struct gsmtap_inst;

    This is not needed, you are already adding gsmtap_util.h abovewhich adds this line.

To view, visit change 34720. To unsubscribe, or for help writing mail filters, visit settings.