pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30821 ) Change subject: bsc: Fix crash if PagingResponse with invalid MobileIdentity is received ...................................................................... bsc: Fix crash if PagingResponse with invalid MobileIdentity is received It was found in a BSC on the field that an MS sending an incorrect MobileIdentity IE (wrong length) in PagingResponse was generating a crash on the BSC. When the MobileIdentity cannot be parsed right now we keep on instead of rejecting the conn. This should change in the future, but it needs further improvements in our TTCN3 tests. For now let's simply validate the subscriber is not NULL; since recently paging optimizations made paging_request_stop() require the subscriber to be non-null. Fixes: 27cb5d3e24d0e39d09bddcbea5c059dfe5bbcf3d Related: SYS#6280 Change-Id: If8b439ff74c5dd690d637d3e3278c75d6cd6b928 --- M src/osmo-bsc/gsm_08_08.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve neels: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c index 37e00f3..3e0683c 100644 --- a/src/osmo-bsc/gsm_08_08.c +++ b/src/osmo-bsc/gsm_08_08.c @@ -440,7 +440,8 @@ paged_from_msc = NULL; paging_reasons = BSC_PAGING_NONE; if (pdisc == GSM48_PDISC_RR && mtype == GSM48_MT_RR_PAG_RESP) { - paging_request_stop(&paged_from_msc, &paging_reasons, bts, conn->bsub); + if (conn->bsub) + paging_request_stop(&paged_from_msc, &paging_reasons, bts, conn->bsub); if (!paged_from_msc) { /* This looks like an unsolicited Paging Response. It is required to pick any MSC, because any * MT-CSFB calls were Paged by the MSC via SGs, and hence are not listed in the BSC. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If8b439ff74c5dd690d637d3e3278c75d6cd6b928 Gerrit-Change-Number: 30821 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged