Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30911 )

Change subject: radio interface: fix init ......................................................................

radio interface: fix init

5561f1129d0bed0ebd2a49fde07e8ee91e487fd6 introduced some changes, but while RadioInterface lost its call to close() that was previously used to improperly reset the buffers upon init() that call was accidentally not removed for RadioInterfaceMulti and RadioInterfaceResamp, so those reset previously initialized values to 0 during init(), which break osmo-trx for weird setups.

Change-Id: I74fc1586f8ae0832f4093ba8a44a1c70c78ec3d8 --- M Transceiver52M/radioInterfaceMulti.cpp M Transceiver52M/radioInterfaceResamp.cpp 2 files changed, 0 insertions(+), 4 deletions(-)

Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve; Verified Hoernchen: Looks good to me, approved

diff --git a/Transceiver52M/radioInterfaceMulti.cpp b/Transceiver52M/radioInterfaceMulti.cpp index eeb0c97..a7195b4 100644 --- a/Transceiver52M/radioInterfaceMulti.cpp +++ b/Transceiver52M/radioInterfaceMulti.cpp @@ -153,8 +153,6 @@ return false; }

- close(); - convertSendBuffer.resize(1); convertRecvBuffer.resize(1);

diff --git a/Transceiver52M/radioInterfaceResamp.cpp b/Transceiver52M/radioInterfaceResamp.cpp index 37167ae..869acd0 100644 --- a/Transceiver52M/radioInterfaceResamp.cpp +++ b/Transceiver52M/radioInterfaceResamp.cpp @@ -98,8 +98,6 @@ { float cutoff = 1.0f;

- close(); - switch (type) { case RadioDevice::RESAMP_64M: resamp_inrate = RESAMP_64M_INRATE;