Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-remsim/+/39023?usp=email )
Change subject: rspro: use osmo_stream to handle IPA connection
......................................................................
Patch Set 6:
(1 comment)
File src/rspro_client_fsm.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/39023/comment/758a97bf_e60d01c3?… :
PS6, Line 226: if (res <= 0) {
Is it safe to call `osmo_ipa_msgb_cb_proto()` before
this check?
Yes, we are simply accessing msgb->cb in the end.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-remsim/+/39023?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I9cba48bf8eba85215acef70eda7bcf8ec13ea49a
Gerrit-Change-Number: 39023
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 05 Dec 2024 22:35:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>